feat: add new conversations.externalInvitePermissions.set API
#1517
+88
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yours has integration tests! Better than my PR. Let's use this PR instead. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1517 +/- ##
==========================================
+ Coverage 84.89% 84.90% +0.01%
==========================================
Files 113 113
Lines 12480 12489 +9
==========================================
+ Hits 10595 10604 +9
Misses 1885 1885 ☔ View full report in Codecov by Sentry. |
filmaj
reviewed
Jun 25, 2024
seratch
reviewed
Jun 25, 2024
|
|
||
| sender_approval = sender.conversations_acceptSharedInvite(invite_id=invite["invite_id"], team_id=connect_team_id) | ||
| self.assertIsNone(sender_approval["error"]) | ||
|
|
There was a problem hiding this comment.
@filmaj @WilliamBergamin To make this test function, perhaps you need to call conversations.approveSharedInvite here. Without that, the followng calls will result in channel_not_found error
seratch
reviewed
Jun 25, 2024
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
…/github.com/WilliamBergamin/python-slack-sdk into conversations.externalInvitePermissions.set
seratch
requested changes
Jul 2, 2024
slack_sdk/web/async_client.py
Outdated
| "target_team": target_team, | ||
| } | ||
| ) | ||
| return await self.api_call("conversations.externalInvitePermissions.set", http_verb="GET", params=kwargs) |
There was a problem hiding this comment.
Can you run the generator script to synchronize the changes?
filmaj
approved these changes
Jul 3, 2024
seratch
approved these changes
Jul 4, 2024
seratch
added a commit
to seratch/python-slack-sdk
that referenced
this pull request
Oct 10, 2024
…accept type RichTextBlock
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a duplicate of #1516 and adds support for https://api.slack.com/methods/conversations.externalInvitePermissions.set
I did not get a chance to test out the integration tests locally, before noticing this was a duplicate
Category (place an
xin each of the[ ])/docs-src(Documents, have you run./scripts/docs.sh?)/docs-src-v2(Documents, have you run./scripts/docs-v2.sh?)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements (place an
xin each[ ])python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.